CVE-2023-49783: No permission checks for editing/deleting records with CSV import form
Impact Users who don't have edit or delete permissions for records exposed in a ModelAdmin can still edit or delete records using the CSV import form, provided they have create permissions. The likelyhood of a user having create permissions but not having edit or delete permissions is low, but it is possible.
Published Jan 23, 2024 · Updated Jan 29, 2024
Affected packages
silverstripe/admin
- Ecosystem
- Composer (PHP)
- Affected
- >= 1.0.0, < 1.13.19
- Fixed in
- 1.13.19
- Check
composer show silverstripe/admin
silverstripe/admin
- Ecosystem
- Composer (PHP)
- Affected
- >= 2.0.0, < 2.1.8
- Fixed in
- 2.1.8
- Check
composer show silverstripe/admin
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Impact
Users who don't have edit or delete permissions for records exposed in a ModelAdmin can still edit or delete records using the CSV import form, provided they have create permissions.
The likelyhood of a user having create permissions but _not_ having edit or delete permissions is low, but it _is_ possible.
Note that this doesn't affect any ModelAdmin which has had the import form disabled via the `showImportForm` public property, nor does it impact the SecurityAdmin section.
Action may be required
If you have a custom implementation of `BulkLoader`, you should update your implementation to respect permissions when the return value of `getCheckPermissions()` is true.
If you are using any BulkLoader in your own project logic, or maintain a module which uses it, you should consider passing true to `setCheckPermissions()` if the data is provided by users.
Base CVSS: 4.3 Reported by: Guy Sartorelli from Silverstripe
References
- https://www.silverstripe.org/download/security-releases/CVE-2023-49783
Credited to ChloeSartorelli.
References
- https://github.com/silverstripe/silverstripe-admin/security/advisories/GHSA-j3m6-gvm8-mhvw
- https://nvd.nist.gov/vuln/detail/CVE-2023-49783
- https://github.com/silverstripe-security/security-issues/issues/177
- https://github.com/silverstripeltd/product-issues/issues/832
- https://github.com/silverstripe/silverstripe-admin/commit/9693130a0a637cdf512277cf5f07e83250b191db
- https://www.silverstripe.org/download/security-releases/CVE-2023-49783
- https://github.com/FriendsOfPHP/security-advisories/blob/master/silverstripe/admin/CVE-2023-49783.yaml
- https://github.com/advisories/GHSA-j3m6-gvm8-mhvw
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
