CVE-2024-21661: Denial of Service (DoS) Vulnerability Due to Unsafe Array Modification in Multi-threaded Environment
Summary An attacker can exploit a critical flaw in the application to initiate a Denial of Service (DoS) attack, rendering the application inoperable and affecting all users. The issue arises from unsafe manipulation of an array in a multi-threaded environment. Details The vulnerability is rooted in the application's code, where an array is being modified while it is being iterated over.
Published Mar 18, 2024 · Updated May 28, 2024
Affected packages
github.com/argoproj/argo-cd
- Ecosystem
- Go
- Affected
- <= 1.8.7
- Fixed in
- No patched version yet
- Check
go list -m github.com/argoproj/argo-cd
github.com/argoproj/argo-cd/v2
- Ecosystem
- Go
- Affected
- < 2.8.13
- Fixed in
- 2.8.13
- Check
go list -m github.com/argoproj/argo-cd/v2
github.com/argoproj/argo-cd/v2
- Ecosystem
- Go
- Affected
- >= 2.9.0, < 2.9.9
- Fixed in
- 2.9.9
- Check
go list -m github.com/argoproj/argo-cd/v2
github.com/argoproj/argo-cd/v2
- Ecosystem
- Go
- Affected
- >= 2.10.0, < 2.10.4
- Fixed in
- 2.10.4
- Check
go list -m github.com/argoproj/argo-cd/v2
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
An attacker can exploit a critical flaw in the application to initiate a Denial of Service (DoS) attack, rendering the application inoperable and affecting all users. The issue arises from unsafe manipulation of an array in a multi-threaded environment.
Details
The vulnerability is rooted in the application's code, where an array is being modified while it is being iterated over. This is a classic programming error but becomes critically unsafe when executed in a multi-threaded environment. When two threads interact with the same array simultaneously, the application crashes.
The core issue is located in expireOldFailedAttempts function:
func expireOldFailedAttempts(maxAge time.Duration, failures *map[string]LoginAttempts) int {
expiredCount := 0
for key, attempt := range *failures {
if time.Since(attempt.LastFailed) > maxAge*time.Second { expiredCount += 1
delete(*failures, key) // Vulnerable code
} }
return expiredCount }The function modifies the array while iterating it which means the code will cause an error and crash the application pod, inspecting the logs just before the crash we can confirm:
goroutine 2032 [running]: github.com/argoproj/argo-cd/v2/util/session.expireOldFailedAttempts(0x12c, 0xc000adecd8)
/go/src/github.com/argoproj/argo-cd/util/session/sessionmanager.go:304 +0x7c github.com/argoproj/argo-cd/v2/util/session.(*SessionManager).updateFailureCount(0xc00035 af50, {0xc001b1f578, 0x11}, 0x1)
/go/src/github.com/argoproj/argo-cd/util/session/sessionmanager.go:320 +0x7f github.com/argoproj/argo-cd/v2/util/session.(*SessionManager).VerifyUsernamePassword(0xc 00035af50, {0xc001b1f578, 0x11}, {0xc000455148, 0x8})PoC
To reproduce the vulnerability, you can use the following steps:
- Launch the application.
- Trigger the code path that results in the
expireOldFailedAttempts()function being called in multiple threads. - In the attached PoC script we are restarting the server in a while loop, causing the application to be unresponsive at all.
Impact
This is a Denial of Service (DoS) vulnerability. Any attacker can crash the application continuously, making it impossible for legitimate users to access the service. The issue is exacerbated because it does not require authentication, widening the pool of potential attackers.
Credited to nadava669, todaywasawesome, crenshaw-dev, jannfis, pasha-codefresh.
References
- https://github.com/argoproj/argo-cd/security/advisories/GHSA-6v85-wr92-q4p7
- https://nvd.nist.gov/vuln/detail/CVE-2024-21661
- https://github.com/argoproj/argo-cd/commit/2a22e19e06aaf6a1e734443043310a66c234e345
- https://github.com/argoproj/argo-cd/commit/5bbb51ab423f273dda74ab956469843d2db2e208
- https://github.com/argoproj/argo-cd/commit/ce04dc5c6f6e92033221ec6d96b74403b065ca8b
- https://github.com/argoproj/argo-cd/blob/54601c8fd30b86a4c4b7eb449956264372c8bde0/util/session/sessionmanager.go#L302-L311
- https://github.com/advisories/GHSA-6v85-wr92-q4p7
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Go vulnerabilities
All Go entriesCVE-2026-77459
Argo CD: AppProject destination-namespace and resource restrictions bypassed by PreDelete/PostDelete resource hooks
critical9.9No fixOct 15, 2026CVE-2026-55797
Argo CD repo-server command injection via crafted SSH repository SOCKS5 proxy URL
high8.8No fixOct 9, 2026CVE-2026-45738
Argo CD: Stored XSS in application link annotations enables developer-to-admin privilege escalation
high7.3No fixMay 19, 2026CVE-2025-55191
Repository Credentials Race Condition Crashes Argo CD Server
medium6.5Sep 30, 2025CVE-2025-59531
Unauthenticated argocd-server panic via a malicious Bitbucket-Server webhook payload
high7.5No fixSep 30, 2025CVE-2025-59537
argo-cd vulnerable unauthenticated DoS via malformed Gogs webhook payload
high7.5No fixSep 30, 2025
