CVE-2024-24567: Vyper's raw_call `value=` kwargs not disabled for static and delegate calls
Summary Vyper compiler allows passing a value in builtin rawcall even if the call is a delegatecall or a staticcall. But in the context of delegatecall and staticcall the handling of value is not possible due to the semantics of the respective opcodes, and vyper will silently ignore the value= argument. A contract search was performed and no vulnerable contracts were found in production.
Published Jan 30, 2024 · Updated Nov 22, 2024
Affected packages
vyper
- Ecosystem
- PyPI
- Affected
- < 0.4.0
- Fixed in
- 0.4.0
- Check
pip show vyper
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
Vyper compiler allows passing a value in builtin raw_call even if the call is a delegatecall or a staticcall. But in the context of delegatecall and staticcall the handling of value is not possible due to the semantics of the respective opcodes, and vyper will silently ignore the value= argument.
A contract search was performed and no vulnerable contracts were found in production.
Details
The IR for raw_call is built in the RawCall class: https://github.com/vyperlang/vyper/blob/9136169468f317a53b4e7448389aa315f90b95ba/vyper/builtins/functions.py#L1100
However, the compiler doesn't validate that if either delegatecall or staticall are provided as kwargs, that value wasn't set. For example, the following compiles without errors:
raw_call(self, call_data2, max_outsize=255, is_delegate_call=True, value=msg.value/2)Impact
If the semantics of the EVM are unknown to the developer, he could suspect that by specifying the value kwarg, exactly the given amount will be sent along to the target. However in fact, no value will be sent.
Here is an example of an potentially problematic implementation of multicall utilizing the raw_call built-in:
value_accumulator: uint256 = empty(uint256)
results: DynArray[Result, max_value(uint8)] = []
return_data: Bytes[max_value(uint8)] = b""
success: bool = empty(bool)
for batch in data:
msg_value: uint256 = batch.value
value_accumulator = unsafe_add(value_accumulator, msg_value)
if (batch.allow_failure == False):
return_data = raw_call(self, batch.call_data, max_outsize=255, value=msg_value, is_delegate_call=True)
success = True
results.append(Result({success: success, return_data: return_data}))
else:
success, return_data = \
raw_call(self, batch.call_data, max_outsize=255, value=msg_value, is_delegate_call=True, revert_on_failure=False)
results.append(Result({success: success, return_data: return_data}))
assert msg.value == value_accumulator, "Multicall: value mismatch"
return resultsPatches
Fixed in https://github.com/vyperlang/vyper/pull/3755
Workarounds
_Is there a way for users to fix or remediate the vulnerability without upgrading?_
References
_Are there any links users can visit to find out more?_
Credited to cyberthirst, pcaversaccio, kuroi8, 0xdeadbeef0x.
References
- https://github.com/vyperlang/vyper/security/advisories/GHSA-x2c2-q32w-4w6m
- https://github.com/vyperlang/vyper/blob/9136169468f317a53b4e7448389aa315f90b95ba/vyper/builtins/functions.py#L1100
- https://nvd.nist.gov/vuln/detail/CVE-2024-24567
- https://github.com/vyperlang/vyper/pull/3755
- https://github.com/vyperlang/vyper/commit/a2df08888c318713742c57f71465f32a1c27ed72
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2024-151.yaml
- https://github.com/advisories/GHSA-x2c2-q32w-4w6m
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More PyPI vulnerabilities
All PyPI entriesGHSA-2r3x-4mrv-mcxf
Vyper: Memory corruption using function calls within tuples / nested calls
medium6.9Oct 6, 2026GHSA-4v7v-gqf9-ww2g
Vyper: Call stack corruption when passing complex type containing non-base type members as argument
medium6.9Oct 6, 2026GHSA-vg88-3v92-rjx2
Vyper: Return inside for loop more than 1 level deep
medium6.3Oct 6, 2026CVE-2025-47285
Vyper's `concat()` builtin may elide side-effects for zero-length arguments
low2.9No fixMay 16, 2025CVE-2025-47774
Vyper's `slice()` may elide side-effects when output length is 0
low2.9No fixMay 16, 2025CVE-2025-26622
Vyper's sqrt doesn't define rounding behavior
low2.3Feb 21, 2025
