CVE-2024-32649: vyper performs multiple eval of `sqrt()` argument built in
Summary Using the sqrt builtin can result in multiple eval evaluation of side effects when the argument has side-effects. The bug is more difficult (but not impossible!) to trigger as of 0.3.4, when the unique symbol fence was introduced (https://github.com/vyperlang/vyper/pull/2914). A contract search was performed and no vulnerable contracts were found in production.
Published Apr 25, 2024 · Updated Jan 21, 2025
Affected packages
vyper
- Ecosystem
- PyPI
- Affected
- < 0.4.0
- Fixed in
- 0.4.0
- Check
pip show vyper
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
Using the sqrt builtin can result in multiple eval evaluation of side effects when the argument has side-effects. The bug is more difficult (but not impossible!) to trigger as of 0.3.4, when the unique symbol fence was introduced (https://github.com/vyperlang/vyper/pull/2914).
A contract search was performed and no vulnerable contracts were found in production.
Details
It can be seen that the build_IR function of the sqrt builtin doesn't cache the argument to the stack: https://github.com/vyperlang/vyper/blob/4595938734d9988f8e46e8df38049ae0559abedb/vyper/builtins/functions.py#L2151
As such, it can be evaluated multiple times (instead of retrieving the value from the stack).
PoC
With at least Vyper version 0.2.15+commit.6e7dba7 the following contract:
c: uint256
@internal
def some_decimal() -> decimal:
self.c += 1
return 1.0
@external
def foo() -> uint256:
k: decimal = sqrt(self.some_decimal())
return self.cpasses the following test:
// SPDX-License-Identifier: MIT
pragma solidity >=0.8.13;
import "../../lib/ds-test/test.sol";
import "../../lib/utils/Console.sol";
import "../../lib/utils/VyperDeployer.sol";
import "../ITest.sol";
contract ConTest is DSTest {
VyperDeployer vyperDeployer = new VyperDeployer();
ITest t;
function setUp() public {
t = ITest(vyperDeployer.deployContract("Test"));
}
function testFoo() public {
uint256 val = t.foo();
console.log(val);
assert (val == 4);
}
}Patches
Patched in https://github.com/vyperlang/vyper/pull/3976.
Impact
No vulnerable production contracts were found.
Credited to cyberthirst.
References
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More PyPI vulnerabilities
All PyPI entriesGHSA-2r3x-4mrv-mcxf
Vyper: Memory corruption using function calls within tuples / nested calls
medium6.9Oct 6, 2026GHSA-4v7v-gqf9-ww2g
Vyper: Call stack corruption when passing complex type containing non-base type members as argument
medium6.9Oct 6, 2026GHSA-vg88-3v92-rjx2
Vyper: Return inside for loop more than 1 level deep
medium6.3Oct 6, 2026CVE-2025-47285
Vyper's `concat()` builtin may elide side-effects for zero-length arguments
low2.9No fixMay 16, 2025CVE-2025-47774
Vyper's `slice()` may elide side-effects when output length is 0
low2.9No fixMay 16, 2025CVE-2025-26622
Vyper's sqrt doesn't define rounding behavior
low2.3Feb 21, 2025
