CVE-2024-37300: Globus `identity_provider` restriction ignored when used with `allow_all` in JupyterHub 5.0
Impact JupyterHub < 5.0, when used with GlobusOAuthenticator, could be configured to allow all users from a particular institution only. The configuration for this would look like: This worked fine prior to JupyterHub 5.0, because allowall did not take precedence over identityprovider. Since JupyterHub 5.0, allowall does take precedence over identityprovider.
Published Jun 12, 2024
Affected packages
oauthenticator
- Ecosystem
- PyPI
- Affected
- < 16.3.1
- Fixed in
- 16.3.1
- Check
pip show oauthenticator
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Impact
JupyterHub < 5.0, when used with GlobusOAuthenticator, could be configured to allow all users from a particular institution only. The configuration for this would look like:
# Require users to be using the "foo.horse" identity provider, often an institution or university
c.GlobusAuthenticator.identity_provider = "foo.horse"
# Allow everyone who has that identity provider to log in
c.GlobusAuthenticator.allow_all = TrueThis worked fine prior to JupyterHub 5.0, because allow_all *did not* take precedence over identity_provider.
Since JupyterHub 5.0, allow_all *does* take precedence over identity_provider. On a hub with the same config, now all users will be allowed to login, regardless of identity_provider. identity_provider will basically be ignored.
This is a documented change in JupyterHub 5.0, but is likely to catch many users by surprise.
Patches
OAuthenticator 16.3.1 fixes the issue with JupyterHub 5.0, and does not affect previous versions.
Workarounds
Do not upgrade to JupyterHub 5.0 when using GlobusOAuthenticator in the prior configuration.
Credited to minrk, yuvipanda, manics.
References
- https://github.com/jupyterhub/oauthenticator/security/advisories/GHSA-gprj-3p75-f996
- https://github.com/jupyterhub/oauthenticator/commit/d1aea05fa89f2beae15ab0fa0b0d071030f79654
- https://nvd.nist.gov/vuln/detail/CVE-2024-37300
- https://jupyterhub.readthedocs.io/en/stable/howto/upgrading-v5.html#authenticator-allow-all-and-allow-existing-users
- https://github.com/advisories/GHSA-gprj-3p75-f996
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
