CVE-2024-53859: `auth.TokenForHost` violates GitHub host security boundary when sourcing authentication token within a codespace
Summary A security vulnerability has been identified in go-gh that could leak authentication tokens intended for GitHub hosts to non-GitHub hosts when within a codespace. Details go-gh sources authentication tokens from different environment variables depending on the host involved: - GITHUBTOKEN, GHTOKEN for GitHub.com and ghe.com - GITHUBENTERPRISETOKEN, GHENTERPRISETOKEN for GitHub Enterprise Server Prior to…
Published Nov 27, 2024 · Updated Dec 12, 2024
Affected packages
github.com/cli/go-gh/v2
- Ecosystem
- Go
- Affected
- <= 2.11.0
- Fixed in
- 2.11.1
- Check
go list -m github.com/cli/go-gh/v2
github.com/cli/go-gh
- Ecosystem
- Go
- Affected
- < 2.11.1
- Fixed in
- No patched version yet
- Check
go list -m github.com/cli/go-gh
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
A security vulnerability has been identified in go-gh that could leak authentication tokens intended for GitHub hosts to non-GitHub hosts when within a codespace.
Details
go-gh sources authentication tokens from different environment variables depending on the host involved:
GITHUB_TOKEN,GH_TOKENfor GitHub.com and ghe.comGITHUB_ENTERPRISE_TOKEN,GH_ENTERPRISE_TOKENfor GitHub Enterprise Server
Prior to 2.11.1, auth.TokenForHost could source a token from the GITHUB_TOKEN environment variable for a host other than GitHub.com or ghe.com when within a codespace.
In 2.11.1, auth.TokenForHost will only source a token from the GITHUB_TOKEN environment variable for GitHub.com or ghe.com hosts.
Impact
Successful exploitation could send authentication token to an unintended host.
Remediation and mitigation
- Upgrade
go-ghto2.11.1 - Advise extension users to regenerate authentication tokens:
- Personal access tokens
- GitHub CLI OAuth app
- Advise extension users to review their personal security log and any relevant audit logs for actions associated with their account or enterprise
Credited to BagToad, williammartin, andyfeller, jtmcg, Ry0taK.
References
- https://github.com/cli/go-gh/security/advisories/GHSA-55v3-xh23-96gh
- https://nvd.nist.gov/vuln/detail/CVE-2024-53859
- https://docs.github.com/en/apps/using-github-apps/reviewing-and-revoking-authorization-of-github-apps#reviewing-your-authorized-github-apps
- https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/reviewing-your-security-log
- https://docs.github.com/en/enterprise-cloud@latest/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/identifying-audit-log-events-performed-by-an-access-token
- https://docs.github.com/en/enterprise-cloud@latest/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens
- https://github.com/cli/go-gh/blob/71770357e0cb12867d3e3e288854c0aa09d440b7/pkg/auth/auth.go#L73-L77
- https://pkg.go.dev/vuln/GO-2024-3295
- https://github.com/advisories/GHSA-55v3-xh23-96gh
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
