CVE-2025-59351: DragonFly vulnerable to panics due to nil pointer dereference when using variables created alongside an error
Impact We found two instances in the DragonFly codebase where the first return value of a function is dereferenced even when the function returns an error (figures 9.1 and 9.2). This can result in a nil dereference, and cause code to panic. The codebase may contain additional instances of the bug. Eve is a malicious actor operating a peer machine. She sends a dfdaemonv1.DownRequest request to her peer Alice.
Published Sep 17, 2025 · Updated Sep 26, 2025
Affected packages
github.com/dragonflyoss/dragonfly
- Ecosystem
- Go
- Affected
- < 2.1.0
- Fixed in
- 2.1.0
- Check
go list -m github.com/dragonflyoss/dragonfly
d7y.io/dragonfly/v2
- Ecosystem
- Go
- Affected
- < 2.1.0
- Fixed in
- 2.1.0
- Check
go list -m d7y.io/dragonfly/v2
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Impact
We found two instances in the DragonFly codebase where the first return value of a function is dereferenced even when the function returns an error (figures 9.1 and 9.2). This can result in a nil dereference, and cause code to panic. The codebase may contain additional instances of the bug.
request, err := source.NewRequestWithContext(ctx, parentReq.Url,
parentReq.UrlMeta.Header)
if err != nil {
log.Errorf("generate url [%v] request error: %v", request.URL, err)
span.RecordError(err)
return err
}Eve is a malicious actor operating a peer machine. She sends a dfdaemonv1.DownRequest request to her peer Alice. Alice’s machine receives the request, resolves a nil variable in the server.Download method, and panics.
Patches
- Dragonfy v2.1.0 and above.
Workarounds
There are no effective workarounds, beyond upgrading.
References
A third party security audit was performed by Trail of Bits, you can see the full report.
If you have any questions or comments about this advisory, please email us at [[email protected]](mailto:[email protected]).
Credited to gaius-qi.
References
- https://github.com/dragonflyoss/dragonfly/security/advisories/GHSA-4mhv-8rh3-4ghw
- https://github.com/dragonflyoss/dragonfly/blob/main/docs/security/dragonfly-comprehensive-report-2023.pdf
- https://nvd.nist.gov/vuln/detail/CVE-2025-59351
- https://pkg.go.dev/vuln/GO-2025-3970
- https://github.com/advisories/GHSA-4mhv-8rh3-4ghw
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Go vulnerabilities
All Go entriesCVE-2026-54637
Dragonfly scheduler v1 and v2 gRPC unauthenticated SSRF via attacker-controlled PeerHost in DownloadTinyFile
medium5.5Jul 6, 2026CVE-2026-49254
Dragonfly Manager OAuth provider client_secret disclosure via unauthenticated GET /api/v1/oauth
low2.9Jul 2, 2026CVE-2026-24124
Dragonfly Manager Job API Unauthenticated Access
high8.9Jan 22, 2026CVE-2025-59345
Dragonfly doesn't have authentication enabled for some Manager’s endpoints
high7.7Sep 17, 2025CVE-2025-59346
Dragonfly vulnerable to server-side request forgery
high7.7Sep 17, 2025CVE-2025-59347
Dragonfly's manager makes requests to external endpoints with disabled TLS authentication
medium5.5Sep 17, 2025
