CVE-2024-35238: Denial of service of Minder Server from maliciously crafted GitHub attestations
Minder is vulnerable to a denial-of-service (DoS) attack which could allow an attacker to crash the Minder server and deny other users access to it. The root cause of the vulnerability is that Minders sigstore verifier reads an untrusted response entirely into memory without enforcing a limit on the response body.
Published May 28, 2024
Affected packages
github.com/stacklok/minder
- Ecosystem
- Go
- Affected
- < 0.0.51
- Fixed in
- 0.0.51
- Check
go list -m github.com/stacklok/minder
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Minder is vulnerable to a denial-of-service (DoS) attack which could allow an attacker to crash the Minder server and deny other users access to it.
The root cause of the vulnerability is that Minders sigstore verifier reads an untrusted response entirely into memory without enforcing a limit on the response body. An attacker can exploit this by making Minder make a request to an attacker-controlled endpoint which returns a response with a large body which will crash the Minder server.
Specifically, the point of failure is where Minder parses the response from the GitHub attestations endpoint in getAttestationReply. Here, Minder makes a request to the orgs/$owner/attestations/$checksumref GitHub endpoint (line 285) and then parses the response into the AttestationReply (line 295):
https://github.com/stacklok/minder/blob/daccbc12e364e2d407d56b87a13f7bb24cbdb074/internal/verifier/sigstore/container/container.go#L271-L300
The way Minder parses the response on line 295 makes it prone to DoS if the response is large enough. Essentially, the response needs to be larger than the machine has available memory.
To demonstrate this in an isolated way, consider the following example:
package main
import (
"encoding/json"
"fmt"
"io"
"strings"
)
type Attestation struct {
Bundle json.RawMessage `json:"bundle"`
}
type AttestationReply struct {
Attestations []Attestation `json:"attestations"`
}
func main() {
m1 := strings.NewReader("{\"attestations\":[")
maliciousBody := strings.NewReader(strings.Repeat("{\"bundle\":{\"k\": \"v\"{{,", 100000000))
m2 := strings.NewReader("{\"bundle\":{\"k\": \"v\"}}]}")
maliciousBodyReader := io.MultiReader(m1, maliciousBody, maliciousBody, maliciousBody, m2)
fmt.Println("Created malicious body")
var attestationReply AttestationReply
_ = json.NewDecoder(maliciousBodyReader).Decode(&attestationReply)
}
This example mimics the behavior of Minders getAttestationReply and how a malicious response body passed to getAttestationReply’s parsing of the response will cause DoS.
When running this script locally on my system, Go incrementally increases memory consumption up to above 90%, freezes the machine and then performs a sigkill.
Attack vector
The content that is hosted at the orgs/$owner/attestations/$checksumref GitHub attestation endpoint is controlled by users including unauthenticated users to Minders threat model. However, a user will need to configure their own Minder settings to cause Minder to make Minder send a request to fetch the attestations. The user would need to know of a package whose attestations were configured in such a way that they would return a large response when fetching them. As such, the steps needed to carry out this attack would look as such:
- The attacker adds a package to ghcr.io with attestations that can be fetched via the
orgs/$owner/attestations/$checksumrefGitHub endpoint. - The attacker registers on Minder and makes Minder fetch the attestations.
- Minder fetches attestations and crashes thereby being denied of service.
Credited to AdamKorcz, DavidKorczynski.
References
- https://github.com/stacklok/minder/security/advisories/GHSA-8fmj-33gw-g7pw
- https://nvd.nist.gov/vuln/detail/CVE-2024-35238
- https://github.com/stacklok/minder/commit/fe321d345b4f738de6a06b13207addc72b59f892
- https://github.com/stacklok/minder/blob/daccbc12e364e2d407d56b87a13f7bb24cbdb074/internal/verifier/sigstore/container/container.go#L271-L300
- https://github.com/advisories/GHSA-8fmj-33gw-g7pw
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Go vulnerabilities
All Go entriesCVE-2024-37904
Minder affected by denial of service from maliciously configured Git repository
medium5.7Jun 18, 2024CVE-2024-35194
Stacklok Minder vulnerable to denial of service from maliciously crafted templates
medium5.3May 20, 2024CVE-2024-35185
Denial of service of Minder Server with attacker-controlled REST endpoint
medium5.3May 16, 2024CVE-2024-34084
Minder's GitHub Webhook Handler vulnerable to DoS from un-validated requests
high7.5May 7, 2024CVE-2024-31455
Minder GetRepositoryByName data leak
medium4.3Apr 9, 2024CVE-2024-27916
`GetRepositoryByName`, `DeleteRepositoryByName` and `GetArtifactByName` allow access of arbitrary repositories in Minder by any authenticated user
high7.1Mar 5, 2024
