CVE-2024-34084: Minder's GitHub Webhook Handler vulnerable to DoS from un-validated requests
Minder's HandleGithubWebhook is susceptible to a denial of service attack from an untrusted HTTP request. The vulnerability exists before the request has been validated, and as such the request is still untrusted at the point of failure. This allows an attacker with the ability to send requests to HandleGithubWebhook to crash the Minder controlplane and deny other users from using it.
Published May 7, 2024 · Updated May 10, 2024
Affected packages
github.com/stacklok/minder
- Ecosystem
- Go
- Affected
- < 0.0.48
- Fixed in
- 0.0.48
- Check
go list -m github.com/stacklok/minder
Advisory details
From the GitHub Advisory Database (CC BY 4.0).
Minder's HandleGithubWebhook is susceptible to a denial of service attack from an untrusted HTTP request. The vulnerability exists before the request has been validated, and as such the request is still untrusted at the point of failure. This allows an attacker with the ability to send requests to HandleGithubWebhook to crash the Minder controlplane and deny other users from using it.
One of the first things that HandleGithubWebhook does is to validate the payload signature. This is done by way of the internal helper validatePayloadSignature:
https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks.go#L213-L218
validatePayloadSignature generates a reader from the incoming request by way of the internal helper readerFromRequest:
https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks.go#L337-L342
To create a reader from the incoming request, readerFromRequest first reads the request body entirely into memory on line 368:
https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks.go#L367-L377
This is a vulnerability, since an HTTP request with a large body can exhaust the memory of the machine running Minder and cause the Go runtime to crash Minder.
Note that this occurs before Minder has validated the request, and as such, the request is still untrusted.
To test this out, we can use the existing TestHandleWebHookRepository unit test and modify the HTTP request body to be large.
To do that, change these lines:
https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks_test.go#L278-L283
... to these lines:
packageJson, err := json.Marshal(event)
require.NoError(t, err, "failed to marshal package event")
maliciousBody := strings.NewReader(strings.Repeat("1337", 1000000000))
maliciousBodyReader := io.MultiReader(maliciousBody, maliciousBody, maliciousBody, maliciousBody, maliciousBody)
_ = packageJson
client := &http.Client{}
req, err := http.NewRequest("POST", fmt.Sprintf("http://%s", addr), maliciousBodyReader)
require.NoError(t, err, "failed to create request")Then run the unit test again. WARNING, SAVE ALL WORK BEFORE DOING THIS.
On my local machine, this causes the machine to freeze, and Go finally performs a sigkill:
signal: killed
FAIL github.com/stacklok/minder/internal/controlplane 30.759s
FAILCredited to AdamKorcz, DavidKorczynski.
References
- https://github.com/stacklok/minder/security/advisories/GHSA-9c5w-9q3f-3hv7
- https://github.com/stacklok/minder/commit/3e5a527d2f1b535159206161d1d519602c75bd0d
- https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks.go#L213-L218
- https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks.go#L337-L342
- https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks.go#L367-L377
- https://github.com/stacklok/minder/blob/ee66f6c0763212503c898cfefb65ce1450c7f5ac/internal/controlplane/handlers_githubwebhooks_test.go#L278-L283
- https://nvd.nist.gov/vuln/detail/CVE-2024-34084
- https://github.com/advisories/GHSA-9c5w-9q3f-3hv7
How this page is made: the data panel comes from the GitHub Advisory Database, CISA’s KEV catalog, the NVD and FIRST EPSS, and updates twice a day. No analysis has been written for this entry yet. Methodology
More Go vulnerabilities
All Go entriesCVE-2024-37904
Minder affected by denial of service from maliciously configured Git repository
medium5.7Jun 18, 2024CVE-2024-35238
Denial of service of Minder Server from maliciously crafted GitHub attestations
medium5.3May 28, 2024CVE-2024-35194
Stacklok Minder vulnerable to denial of service from maliciously crafted templates
medium5.3May 20, 2024CVE-2024-35185
Denial of service of Minder Server with attacker-controlled REST endpoint
medium5.3May 16, 2024CVE-2024-31455
Minder GetRepositoryByName data leak
medium4.3Apr 9, 2024CVE-2024-27916
`GetRepositoryByName`, `DeleteRepositoryByName` and `GetArtifactByName` allow access of arbitrary repositories in Minder by any authenticated user
high7.1Mar 5, 2024
